Add link to examples in README #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can add a link to v2x for more examples when chipsalliance/f4pga-v2x#42 is merged as per #12 |
mithro
reviewed
Apr 21, 2020
diagrams/carry4-flatten.svg
Outdated
| @@ -0,0 +1,317 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:s="https://github.com/nturley/netlistsvg" width="511" height="435.5"> | |||
There was a problem hiding this comment.
I don't think we need a new folder for this? Let's just put it at the top level or in the ./docs/ directory?
mithro
approved these changes
Apr 21, 2020
daniellimws
force-pushed
the
readme-example
branch
from
4dae3db
to
8726d72
Compare
|
@mithro ping |
|
Looks like this change needs to be rebased? |
daniellimws
force-pushed
the
readme-example
branch
from
8726d72
to
9851aa5
Compare
Signed-off-by: Daniel Lim Wee Soong <[email protected]>
Signed-off-by: Daniel Lim Wee Soong <[email protected]>
daniellimws
force-pushed
the
readme-example
branch
from
9851aa5
to
0eb4fc7
Compare
|
Oh my bad. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #8
Signed-off-by: Daniel Lim Wee Soong [email protected]