Create action and filter context factories

[loic425]

In Sylius resource bundle, a Twig Grid renderer decorates the grid one in order to add some data to the context (Twig context here but the renderer does not depends on Twig).

Cause I need to add things on resource side to this context, I think it will be easier to allow decorating that context instead.

Example for the future in Resource package to improve that https://github.com/Sylius/SyliusResourceBundle/blob/1.11/src/Bundle/Grid/Renderer/TwigGridRenderer.php#L64

final class ActionContextFactory implemented ActionContextFactoryInterface
{
    public function __construct(
        private ActionContextFactoryInterface $contextFactory,
        private OptionsParserInterface $optionsParser,
    ) {
    }

    public function create(GridViewInterface $gridView, Action $action, mixed $data = null): array
    {
        $options = $this->optionsParser->parseOptions(
            $action->getOptions(),
            $gridView->getRequestConfiguration()->getRequest(),
            $data,
        );

        return array_merge($this->contextFactory->create($grid, $action, $data), [
            'grid' => $gridView,
            'action' => $action,
            'data' => $data,
            'options' => $options,
        ]);
    }
}

Cause I will also need to add new context data when using the new routing system.

[diimpp]

(I'm just thinking out load, it's not a call to action.)

It's a bit strange to have Context/Factory/ActionContextFactoryInterface, but no actual ActionContext as "context" is array and no factoring is happening.

It's more like formatter or provider.

Is there any point adding parameter bag as in TwigHooks for that?

[diimpp]

Suggested change

[diimpp]

Just an idea, this approach is less error prone, less code and seems what sylius uses in newer bundles, like ApiBundle.

Suggested change

	<import resource="services/field_types.xml" />
	<import resource="services/filters.xml" />
	<import resource="services/renderer_context.xml" />
	<import resource="services/templating.xml" />
	<import resource="services/twig.xml" />
	<import resource="services/*.xml" />

Suggested change

	<import resource="services/field_types.xml" />
	<import resource="services/filters.xml" />
	<import resource="services/renderer_context.xml" />
	<import resource="services/templating.xml" />
	<import resource="services/twig.xml" />
	<import resource="services/**/*.xml" />

https://github.com/Sylius/Sylius/blob/b7d92a66caed63094d820296d20d00a1bee0ed04/src/Sylius/Bundle/ApiBundle/Resources/config/services.xml#L18-L20

[diimpp]

Suggested change

[loic425]

(I'm just thinking out load, it's not a call to action.)

It's a bit strange to have Context/Factory/ActionContextFactoryInterface, but no actual ActionContext as "context" is array and no factoring is happening.

It's more like formatter or provider.

Interesting solution here https://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Serializer/Context/ContextBuilderInterface.php