✨ Allow join on ExpressionBuilder comparison #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Fabien! Thanks a lot for your contribution, but without a functional test, we won't merge this PR. Could you add it? |
|
I'd like to, but I'm really not sure how to do it. There isn't a lot of examples in the Functional test folder, and nothing looks really close to what I'm trying to do. Do you have any documentation or similar test cases that I could read to help me create a test case ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing for the compare method of ExpressionBuilder to join on different table before comparing.
It is currently not possible to compare two fields which are in a joined table.