Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update guardians-sdk to v1.10.1 and improve certificate issuance process #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −6
Open

chore: Update guardians-sdk to v1.10.1 and improve certificate issuance process #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2260594
chore: bump guardian sdk
jilio Oct 10, 2024
1feefaa
fix: handle callback error
jilio Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
github.com/biter777/countries v1.7.5
github.com/dgraph-io/badger/v4 v4.2.0
github.com/ethereum/go-ethereum v1.14.8
github.com/galactica-corp/guardians-sdk v1.9.0
github.com/galactica-corp/guardians-sdk v1.10.1
github.com/go-playground/validator/v10 v10.19.0
github.com/iden3/go-iden3-crypto v0.0.16
github.com/joho/godotenv v1.5.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ github.com/fsnotify/fsnotify v1.7.0 h1:8JEhPFa5W2WU7YfeZzPNqzMP6Lwt7L2715Ggo0nos
github.com/fsnotify/fsnotify v1.7.0/go.mod h1:40Bi/Hjc2AVfZrqy+aj+yEI+/bRxZnMJyTJwOpGvigM=
github.com/gabriel-vasile/mimetype v1.4.3 h1:in2uUcidCuFcDKtdcBxlR0rJ1+fsokWf+uqxgUFjbI0=
github.com/gabriel-vasile/mimetype v1.4.3/go.mod h1:d8uq/6HKRL6CGdk+aubisF/M5GcPfT7nKyLpA0lbSSk=
github.com/galactica-corp/guardians-sdk v1.9.0 h1:069gj1u/hUqCHp8qcwbLv/RRKYzr93V+198U2k/o33E=
github.com/galactica-corp/guardians-sdk v1.9.0/go.mod h1:7PZ7QwUCGj3YEdjAWfyqXrXZaPDdMvOzDiaQTl+9mzo=
github.com/galactica-corp/guardians-sdk v1.10.1 h1:hdzulQIeav5Y37PCLaRXTnaUG1S4aIcLGNo69l/t/84=
github.com/galactica-corp/guardians-sdk v1.10.1/go.mod h1:7PZ7QwUCGj3YEdjAWfyqXrXZaPDdMvOzDiaQTl+9mzo=
github.com/gballet/go-libpcsclite v0.0.0-20190607065134-2772fd86a8ff h1:tY80oXqGNY4FhTFhk+o9oFHGINQ/+vhlm8HFzi6znCI=
github.com/gballet/go-libpcsclite v0.0.0-20190607065134-2772fd86a8ff/go.mod h1:x7DCsMOv1taUwEWCzT4cmDeAkigA5/QCwUodaVOe8Ww=
github.com/getsentry/sentry-go v0.27.0 h1:Pv98CIbtB3LkMWmXi4Joa5OOcwbmnX88sF5qbK3r3Ps=
Expand Down
9 changes: 9 additions & 0 deletions internal/api/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,15 @@ func (h *Handlers) GenerateCert(c echo.Context) error {
Info("cert created")

callback := func(issuedCert zkcertificate.IssuedCertificate[zkcertificate.KYCContent], err error) {
if err != nil {
log.WithError(err).Error("cert issuance")

if err := deleteUserDataFromDB(h.inMem, req.UserID); err != nil {
log.WithError(err).Error("clean up db after cert issuance")
}
return
}

log.WithField("holderCommitment", hc).
WithField("userID", req.UserID).
Info("certificate issued")
Expand Down
6 changes: 6 additions & 0 deletions internal/api/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ func readCertFromDB(db *badger.DB, userID UserID) (string, error) {
return string(certData), nil
}

func deleteUserDataFromDB(db *badger.DB, userID UserID) error {
return db.Update(func(txn *badger.Txn) error {
return txn.Delete([]byte(userID))
})
}

func stripToSix(hash zkcertificate.Hash) string {
s := hash.String()
if len(s) > 6 {
Expand Down
3 changes: 0 additions & 3 deletions internal/zkcert/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,6 @@ func (s *Service) AddZKCertToQueue(
) {
s.taskQueue.Add(tq.NewTask(
func() (zkcertificate.IssuedCertificate[zkcertificate.KYCContent], error) {
// This is to give the merkle proof service time to "see" the latest merkle proof root
time.Sleep(3 * time.Second)

_, issuedCert, err := cmd.IssueZKCert(ctx, certificate, s.EthClient, s.merkleProofClient, s.registryAddress, s.providerKey)
if err != nil {
log.WithError(err).Error("issue zk certificate")
Expand Down