-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Bomb with MrBomb #3002
Merge Bomb with MrBomb #3002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just what I needed. Works great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this really does work yup mhm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mr. Bomb and Gold Bomb seem to work fine. I'm not sure what the mentioned issue was, so I trust you that it's been fixed.
Left some code-related comments.
@weluvgoatz I accidentally requested your review. |
Co-authored-by: Vankata453 <[email protected]>
This PR internally rewrites MrBomb to be more like GoldBomb. It doesn't add any considerable features.
It also removes lots of code duplication. The Bomb class is now obsolete.
As a result, the death script stays consistent between MrBomb and GoldBomb.
This PR also fixes a bug with gold bomb, in which getting out of the safe distance and going back in would freeze gold bomb in the same sprite action until another state change.