Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raycast function returns what it hit #2631

Merged
merged 5 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions src/collision/collision_system.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -690,8 +690,11 @@ CollisionSystem::is_free_of_movingstatics(const Rectf& rect, const CollisionObje
return true;
}

bool
CollisionSystem::free_line_of_sight(const Vector& line_start, const Vector& line_end, bool ignore_objects, const CollisionObject* ignore_object) const
CollisionSystem::RaycastResult
CollisionSystem::get_first_line_intersection(const Vector &line_start,
const Vector &line_end,
Vankata453 marked this conversation as resolved.
Show resolved Hide resolved
bool ignore_objects,
const CollisionObject *ignore_object) const
Vankata453 marked this conversation as resolved.
Show resolved Hide resolved
{
using namespace collision;

Expand All @@ -709,29 +712,42 @@ CollisionSystem::free_line_of_sight(const Vector& line_start, const Vector& line
{
continue;
}

const Tile& tile = solids->get_tile_at(test_vector);

const Tile* tile = &solids->get_tile_at(test_vector);

// Get the rect of the tile.
const Rectf tilebox(glm::floor((test_vector - solids->get_offset()) / 32.0f), Sizef(32.f, 32.f));

// FIXME: check collision with slope tiles
if ((tile.get_attributes() & Tile::SOLID)) return false;
if ((tile->get_attributes() & Tile::SOLID))
return {true, true, nullptr, tile, tilebox};
}
}
}

if (ignore_objects)
return true;
return {false};

// Check if no object is in the way.
for (const auto& object : m_objects) {
if (object == ignore_object) continue;
if (!object->is_valid()) continue;
if ((object->get_group() == COLGROUP_MOVING)
|| (object->get_group() == COLGROUP_MOVING_STATIC)
|| (object->get_group() == COLGROUP_STATIC)) {
if (intersects_line(object->get_bbox(), line_start, line_end)) return false;
|| (object->get_group() == COLGROUP_STATIC))
{
if (intersects_line(object->get_bbox(), line_start, line_end))
return {true, false, object};
}
}

return true;
return {false};
}

bool
CollisionSystem::free_line_of_sight(const Vector& line_start, const Vector& line_end, bool ignore_objects, const CollisionObject* ignore_object) const
{
return !get_first_line_intersection(line_start, line_end, ignore_objects, ignore_object).is_valid;
}

std::vector<CollisionObject*>
Expand Down
14 changes: 14 additions & 0 deletions src/collision/collision_system.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,20 @@ class CollisionSystem final
bool is_free_of_tiles(const Rectf& rect, const bool ignoreUnisolid = false, uint32_t tiletype = Tile::SOLID) const;
bool is_free_of_statics(const Rectf& rect, const CollisionObject* ignore_object, const bool ignoreUnisolid) const;
bool is_free_of_movingstatics(const Rectf& rect, const CollisionObject* ignore_object) const;

struct RaycastResult
{
const bool is_valid; /**< true if raycast hit something */
const bool is_tile = true; /**< true if raycast hit a tile */
const CollisionObject* object = nullptr; /**< object that the raycast hit, nullptr if is_tile is true */
const Tile* tile = nullptr; /**< tile that the raycast hit, nullptr if is_tile is false */
Vankata453 marked this conversation as resolved.
Show resolved Hide resolved
const Rectf tile_box = {}; /**< hitbox of tile, empty if is_tile is false */
};
Vankata453 marked this conversation as resolved.
Show resolved Hide resolved

RaycastResult get_first_line_intersection(const Vector& line_start,
const Vector& line_end,
bool ignore_objects,
const CollisionObject* ignore_object) const;
bool free_line_of_sight(const Vector& line_start, const Vector& line_end, bool ignore_objects, const CollisionObject* ignore_object) const;

std::vector<CollisionObject*> get_nearby_objects(const Vector& center, float max_distance) const;
Expand Down
Loading