Tuxs action updates regardless of whether Tux is being drawn. #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically when `Tux.get_visible()` is false Tux's sprite isn't updated at all. This interferes with `Tux.get_action()` because it relies on the sprite updating. What I'm gonna do to fix this is make Tux's sprite update regardless but only draw Tux if `Tux.get_visible()` is true.
Vankata453
reviewed
Aug 25, 2023
|
Drafting this for now because I just found a pretty big bug. Apparently if you abort a level in the editor it crashes with this segmentation fault: If anyone knows whats wrong please let me know. I will continue playing around with this in the meantime. |
|
lol nevermind i fixed it |
Vankata453
approved these changes
Aug 26, 2023
mrkubax10
approved these changes
Aug 28, 2023
mrkubax10
added
category:code
involves:scripting
status:needs-review
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok hear me out...
Basically it fixes
Tux.get_action()not giving the correct action when Tux isn't being drawn.When
Tux.get_visible()is false Tux's sprite isn't updated at all. This interferes withTux.get_action()because it relies on the sprite updating. What I'm gonna do to fix this is make Tux's sprite update regardless of whether Tux is visible but only draw Tux ifTux.get_visible()is true.