Only show supported directions for each object that has Direction #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge all switch sprites into one with directions add up and down switches
tobbi
reviewed
Aug 6, 2023
Vankata453
added a commit
to Vankata453/supertux
that referenced
this pull request
Aug 8, 2023
Pull request SuperTux#2572 moves all switch variants into one sprite file, where the different switch types are managed via Directions. [ci skip]
this ensures compatibility with existing custom switch sprites
…different from Direction::AUTO if needed
Vankata453
reviewed
Aug 9, 2023
mrkubax10
added
involves:editor
category:code
status:needs-review
Vankata453
approved these changes
Aug 12, 2023
mrkubax10
approved these changes
Aug 14, 2023
|
For certain objects such as the bonus block every time you placed one it would bring a warning like |
tobbi
approved these changes
Aug 14, 2023
|
@tylerandari13 I am fixing how |
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most badguys, this is just
auto,leftandright. For some,upanddownbut notauto. For other objects, it varies -Darthasauto,left,right,up,down,DartTrapthe same but withoutauto,PushButtonhasupanddown,Bumperleftandright. TheSwitchhasnone,left,right,upanddown(I addedupanddownin this PR).The bumper and the button used to have a
boolinstead of aDirection, I replaced those but made sure that levels saved with the oldboolwould load correctly and figure out the proper direction.With switches, I replaced the three sprites with just one that supports directions. This does mean that old levels that used left or right switches will default to
switch.spriteand showDirection::NONEswitches, but that shouldn't matter much since those won't look out of place.Also, code quality and guidelines in the files I touched.
direction_limit.mp4
NOTE: This will require proper testing, the more people test, the better. Especially if all directions save and load properly.