Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create objects from scripting #2564

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Create objects from scripting #2564

merged 3 commits into from
Aug 7, 2023

Conversation

tobbi
Copy link
Member

@tobbi tobbi commented Jul 31, 2023

Fixes #2445

@tobbi tobbi self-assigned this Jul 31, 2023
@tobbi
Copy link
Member Author

tobbi commented Jul 31, 2023

Actually, as for # 366 this only fixes the first two things.

@Vankata453
Copy link
Member

Wouldn't this be better suited for the Sector scripting class? That way it'd be accessible for the current sector from sector.settings.

@tobbi
Copy link
Member Author

tobbi commented Aug 1, 2023

Default arguments will not be possible anymore then:

function add_object(class_name, name, posX, posY, direction = "left", data = "")
{
  Level_add_object(class_name, name, posX, posY, direction, data);
}

@tobbi tobbi force-pushed the create_objects_from_scripting branch from 8e3f8f6 to 91acebe Compare August 1, 2023 10:08
@tobbi tobbi force-pushed the create_objects_from_scripting branch from 8e36c3e to b64305d Compare August 1, 2023 10:28
@tobbi tobbi requested a review from Rusty-Box August 1, 2023 17:16
src/scripting/sector.hpp Outdated Show resolved Hide resolved
@tobbi tobbi merged commit 96660b9 into master Aug 7, 2023
33 of 36 checks passed
@mrkubax10 mrkubax10 deleted the create_objects_from_scripting branch August 11, 2023 11:58
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to manually spawn enemies/objects via scripting.
3 participants