-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create objects from scripting #2564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, as for # 366 this only fixes the first two things. |
mrkubax10
added
type:feature
category:code
involves:scripting
status:needs-review
Work needs to be reviewed by other people
labels
Aug 1, 2023
Wouldn't this be better suited for the |
Default arguments will not be possible anymore then: function add_object(class_name, name, posX, posY, direction = "left", data = "")
{
Level_add_object(class_name, name, posX, posY, direction, data);
} |
tobbi
force-pushed
the
create_objects_from_scripting
branch
from
August 1, 2023 10:08
8e3f8f6
to
91acebe
Compare
tobbi
force-pushed
the
create_objects_from_scripting
branch
from
August 1, 2023 10:28
8e36c3e
to
b64305d
Compare
mrkubax10
approved these changes
Aug 1, 2023
Vankata453
reviewed
Aug 6, 2023
Vankata453
approved these changes
Aug 7, 2023
mrkubax10
removed
the
status:needs-review
Work needs to be reviewed by other people
label
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2445