Fix sprite fallback issues #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, missing ".sprite" files, when attempted to be loaded, would immeditately close the game, due to throwing fatal errors. The issue is now fixed. Such errors are caught, and the fallback/dummy texture takes the sprite's place. Other than ".sprite" file load errors being caught, single-image sprites also throw an error, when the chosen image fails to load. `MovingSprite`s now return to their default sprite, if a custom-set sprite fails to load.
Vankata453
added
category:code
status:needs-review
Rusty-Box
approved these changes
Jul 21, 2023
mrkubax10
approved these changes
Jul 21, 2023
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, missing
.spritefiles, when attempted to be loaded, would immediately close the game, due to throwing fatal errors. The issue is now fixed. Such errors are caught, and the fallback/dummy texture takes the sprite's place.Other than
.spritefile load errors being caught, single-image sprites also throw an error, which is later caught, when the chosen image fails to load.MovingSprites now return to their default sprite, if a custom-set sprite fails to load.Fixes #2341. Closes #2250.