Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap new tiles to compatible mapping #2462

Closed
wants to merge 15 commits into from

Conversation

Semphriss
Copy link
Member

@Semphriss Semphriss commented May 5, 2023

image

Fixes #2306

The new tiles have been remapped according to their old IDs.

TODO:

  • Remap forest tiles
  • Remap ghost forest tiles

@Semphriss Semphriss changed the title Tiles fix Remap new tiles to compatible mapping May 6, 2023
@Semphriss Semphriss marked this pull request as ready for review May 7, 2023 20:37
@Semphriss
Copy link
Member Author

Note: The PR duplicates the whole images folder across the commit history. When (or before) merging, please delete data/images_old/ and squash to remove it from the git history.

This commit remaps the tiles to their old ID mappings, prior to the breaking changes on October 2022.

Co-authored-by: Vankata453 <[email protected]>
@tulpenkiste
Copy link
Contributor

tulpenkiste commented Jun 30, 2023

Did some performance tests between this and nightly 750:

  • SDL 2.0.10 with Draw Redundant Frames on (latest nightly)
    • 500fps average
  • SDL 2.0.10 with Draw Redundant Frames on (this pr)
    • 450fps average
  • OpenGL 3.3 with Draw Redundant Frames on and vsync off (latest nightly)
    • 400fps average
  • OpenGL 3.3 with Draw Redundant Frames on and vsync off (this pr)
    • 400fps average

Vankata wondered if the performance differences between latest nightly and this pr using SDL2 is due to tiles being re-added.

@Semphriss
Copy link
Member Author

I haven't succeeded reproducing this, so as we discussed, if you could try with a profiler and send your results, it would help me.

@Semphriss Semphriss force-pushed the tiles-fix branch 2 times, most recently from 711b1fd to 4a8f30d Compare July 8, 2023 17:43
@Vankata453
Copy link
Member

Closing due to the merge of #2671.

@Vankata453 Vankata453 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent tileset changes broken
3 participants