-
-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor WorldMap to support functional sectors #2377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkubax10
added
category:code
involves:scripting
status:needs-review
Work needs to be reviewed by other people
type:bugfix
Pull Requests that fix bugs.
labels
Jan 15, 2023
Could you fix build errors? |
Could you fix merge conflicts? |
mrkubax10
approved these changes
Jul 12, 2023
Vankata453
force-pushed
the
worldmap-refactor
branch
from
July 12, 2023 22:52
2ba051d
to
240d72a
Compare
mrkubax10
approved these changes
Jul 16, 2023
tobbi
approved these changes
Jul 16, 2023
mrkubax10
removed
the
status:needs-review
Work needs to be reviewed by other people
label
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
WorldMap
class, which supports functional sectors. Teleporting to a different sector in the same worldmap is now possible. This removes the need for using the unintuitive in most cases alternative, which is having multiple worldmaps.WorldMapSector
is the new class which handles sectors in a worldmap. It inheritsSectorBase
, which is a base for theSector
class that is used in levels, but only with its basic properties and functions included. This allowsWorldMapSector
to be parsed usingWorldMapSectorParser
, which inheritsSectorParser
.Teleporting from one sector to another is possible both with scripting and using teleporters.
This pull request also features some general organizations/improvements to worldmap-related code:
GameObject
's parentGameObjectManager
.Fixes #1511.