possibly fix comp errors

SuperTux · Sep 3, 2023 · 5a89198 · 5a89198
1 parent d6086f0
commit 5a89198
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/editor/object_option.cpp b/src/editor/object_option.cpp
@@ -412,15 +412,15 @@ FileObjectOption::FileObjectOption(const std::string& text, std::string* pointer
                                    std::vector<std::string> filter,
                                    const std::string& basedir,
                                    bool path_relative_to_basedir,
-                                   std::vector<std::string> additional_filter,
+                                   const std::vector<std::string>& additional_filter,
                                    unsigned int flags) :
   ObjectOption(text, key, flags),
   m_pointer(pointer),
   m_default_value(std::move(default_value)),
   m_filter(std::move(filter)),
   m_basedir(basedir),
   m_path_relative_to_basedir(path_relative_to_basedir),
-  m_additional_filter(std::move(additional_filter))
+  m_additional_filter(additional_filter)
 {
 }
 

diff --git a/src/editor/object_option.hpp b/src/editor/object_option.hpp
@@ -280,7 +280,7 @@ class FileObjectOption : public ObjectOption
                    std::vector<std::string> filter,
                    const std::string& basedir,
                    bool path_relative_to_basedir,
-                   std::vector<std::string> additional_filter = {},
+                   const std::vector<std::string>& additional_filter = {},
                    unsigned int flags = 0);
 
   virtual void save(Writer& write) const override;
@@ -291,9 +291,9 @@ class FileObjectOption : public ObjectOption
   std::string* const m_pointer;
   std::optional<std::string> m_default_value;
   const std::vector<std::string> m_filter;
-  const std::vector<std::string> m_additional_filter;
   std::string m_basedir;
   bool m_path_relative_to_basedir;
+  const std::vector<std::string> m_additional_filter;
 
 private:
   FileObjectOption(const FileObjectOption&) = delete;