Prototype interface changes #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `binned_histogram` - Updated FeI2 example to include binning - Added Binning Tutorial as an example (maybe this should go in a subfolder?) - Added energy broadening for binned data - Added `connected_path_bins` for making spaghetti plots while recording the binning parameters for each subplot (for use in Mantid) * Add `intensities_bin_centers(swt,...)` for SWT fake-binning (The correct calculation involves integrating over bins) * Implement histogram binned powder averaging (& added to powder tutorial)
It now automatically calculates a very conservative estimate of how many BZ's you need to fill out the histogram, or can be manually specified. The example now demonstrates plotting each BZ individually; hopefully it's not too slow!
The binwidth should always be set just a tad large so that the `binend` value always falls solidly within the last bin. This prevents "ragged edge" empty bins at the far edge of histograms
* Proposed modifications to the interface * Standardize pretty-printing of System and StructureFactor * Add IntensityFormula types * Fix things in docs without tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(contains breaking changes, but is ready to merge/get feedback)