Get to zero allocations in sampling and dynamics #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @Lazersmoke's recent excellent work in reducing allocations (#78), I think we should push it all the way and ensure through unit tests that sampling and dynamics never allocate. We're not there yet, so this PR is aspirational. Progress can be added as commits on the branch
zero-alloc, and we can merge this PR when all tests pass.For reference, here is how to view where allocations are happening: https://docs.julialang.org/en/v1/manual/profile/#Allocation-Profiler