chore: remove error for 100% fees

SundaeSwap-finance · Jul 10, 2024 · 45cf203 · 45cf203
1 parent eb36ecf
commit 45cf203
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/cpp/src/ConstantProductPool.ts b/packages/cpp/src/ConstantProductPool.ts
@@ -190,8 +190,8 @@ export const getSwapOutput = (
     throw new Error("Input and reserves must be positive");
 
   fee = Fraction.asFraction(fee);
-  if (fee.lt(Fraction.ZERO) || fee.gte(Fraction.ONE))
-    throw new Error("fee must be [0,1)");
+  if (fee.lt(Fraction.ZERO) || fee.gt(Fraction.ONE))
+    throw new Error("fee must be between 0 and 1");
 
   const feeDiff = fee.denominator - fee.numerator;
   const outputNumerator = outputReserve * input * feeDiff;

diff --git a/packages/cpp/src/__tests__/ConstantProductPool.test.ts b/packages/cpp/src/__tests__/ConstantProductPool.test.ts
@@ -28,7 +28,9 @@ describe("getSwapOutput", () => {
   });
 
   test("throws if fee is greater than or equal 1", () => {
-    expect(() => getSwapOutput(1n, 10n, 10n, Fraction.asFraction(1))).toThrow();
+    expect(() =>
+      getSwapOutput(1n, 10n, 10n, Fraction.asFraction(1)),
+    ).not.toThrow();
     expect(() =>
       getSwapOutput(1n, 10n, 10n, Fraction.asFraction(1.132)),
     ).toThrow();