Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new recipe for visit tracking #33

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

coolbung
Copy link

No description provided.

@coolbung
Copy link
Author

coolbung commented Oct 6, 2022

@surendrasinghs @anandp504 @SanthoshVasabhaktula please help with merging this.

KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1

telemetry-service:
image: coolbung/telemetry-service:release-3.3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coolbung - Is the reference correct? I assume it should be pointing to sunbird image?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find an image for release-3.3.0, so have left it to my account.
https://hub.docker.com/r/sunbird/telemetry-service/tags (No release-3.3.0)
https://hub.docker.com/r/sunbirddev/telemetry-service/tags (This has RC1, but not release-3.3.0)

The previous step includes creation of the image, so have added a suggestion in the docs to change the telemetry image path in the installation guide.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keshavprasadms - Can you please point to the right image for telemetry service?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coolbung Have pushed the image. Please use release-3.3.0_RC1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Have updated the docker compose file to use this. Please merge if all is good

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SanthoshVasabhaktula can you help merge this

changed docker compose to point to sunbird provided image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants