Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for [C4GT Community]: Implementation of Collapsible Sidebar Menu - #30 #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sonisumit7904
Copy link

@sonisumit7904 sonisumit7904 commented Mar 19, 2024

Ticket Contents

Fix for- #30

Description

This ticket involves implementing a collapsible sidebar menu within our application. Currently, the sidebar menu exists but is not collapsible. By making it collapsible, we can utilize extra space more efficiently and provide users with a more flexible navigation experience.

Goals

  • Implement a collapsible sidebar menu that can be expanded or collapsed by users.
  • Ensure smooth transition animations for expanding and collapsing the sidebar.
  • Enhance user experience by providing additional space for content when the sidebar is collapsed.

Expected Outcome

The final product should include a sidebar menu that can be collapsed to free up space for content or expanded to display navigation options. Users should be able to toggle the visibility of the sidebar with ease.

@gouravmore Please review and give your opinion!

Final_Sidebar.mp4

Copy link

@Savio629 Savio629 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonisumit7904 It's better if you revert unwanted changes in angular.json and package-lock.json

@Savio629
Copy link

@gouravmore Also while going through the code, I found out there are many repeated code in folders such as hindi-version, kannada-version, and tamil-version. We could consolidate these redundant code segments into a shared module or components to promote code reusability and maintainability across different language versions.

@sonisumit7904 sonisumit7904 reopened this Mar 20, 2024
@sonisumit7904
Copy link
Author

@sonisumit7904 It's better if you revert unwanted changes in angular.json and package-lock.json

Thanks, I have followed your advice

@gouravmore Also while going through the code, I found out there are many repeated code in folders such as hindi-version, kannada-version, and tamil-version. We could consolidate these redundant code segments into a shared module or components to promote code reusability and maintainability across different language versions.

I think that's a good idea, but we should first wait for @gouravmore for his opinion, before making big changes to code like that.

Copy link

sonarcloud bot commented Jun 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants