ci: build & test otelcol-config #1656
Conversation
| # TODO: find a way to test if the binary runs | ||
| # - name: Test binary | ||
| # if: inputs.arch_os == env.ARCH_OS | ||
| # working-directory: ./pkg/tools/otelcol-config | ||
| # run: | | ||
| # ./${{ steps.set-binary-name.outputs.binary_name }} -t foo |
There was a problem hiding this comment.
There's already a smoke test in otelcol-config itself, so this is probably not needed
There was a problem hiding this comment.
This was copied from the otelcol-sumo build job. It's meant to ensure that the binary runs after running make. We ran into an issue where the binaries were actually text files in the past.
It may be better to check the file type for every platform instead. We'd need to check for the correct file type for the platform though (e.g. Mach-O 64-bit executable arm64 versus ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=vataBbMZrfQgeqsJPb3y/CT0CNbBkuU-ZpeiBCFvZ/rX1IRAQtPBnQNJWqqDt9/SENzp0KECm910ny3Zm29, stripped)
There was a problem hiding this comment.
That seems kind of nitty to me. How did it regress to a text file?
There was a problem hiding this comment.
I'm not positive but I believe it was a problem with binaries moving between jobs through the CI cache system which isn't happening the same way here. We can leave this out.
|
@echlebek ready for review! |
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
Signed-off-by: Justin Kolberg <[email protected]>
amdprophet
force-pushed
the
dev-build/ci-otelcol-config
branch
from
75c8f47
to
3a30268
Compare
Adds build & test CI jobs for the new otelcol-config command. Refactors the toolchain code used for building FIPS images to allow the Docker container to build other binaries.