Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove URL-rewriting hack #1519

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove URL-rewriting hack #1519

wants to merge 3 commits into from

Conversation

echlebek
Copy link
Contributor

This commit removes a hack that rewrites the collector URL for use with OpAmp. The collector now supports redirection, and we expect the Sumo Logic backend to correctly redirect the client.

@echlebek echlebek requested a review from a team as a code owner March 27, 2024 02:37
@echlebek
Copy link
Contributor Author

Notes for reviewers:

  • tested successfully against us2data long, with remote management (I don't know if redirection occurred or not)
  • users should not notice any difference, I think it's probably better to omit a changelog entry

@echlebek echlebek self-assigned this Mar 27, 2024
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good to me, but we should check against a few more environments than just us2. We should also get approval from the relevant Opamp backend SMEs before merging this imo.

Copy link

@skumar-sumo skumar-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this changes behind feature flag rather removing the old code.
As the otrm for existing customers will break till we test this feature end-to-end on production.

@echlebek
Copy link
Contributor Author

@skumar-sumo I don't see the logic of having a feature flag here, what's the suggested default? Can't we support both the old and new strategy on the backend?

Copy link

@ggautam-sumo ggautam-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break OT remote management. As of now,

  1. Backend changes are not tested. Its pending on Agent build that supports http/wss redirection.
  2. After testing with Agent, BE solution will be rollout on test environment and then to small prods.
  3. We would also need QE sign off on the redirection solution to rollout everywhere.
  4. We don't have a rollback solution discussed or in place. (Hope we don't need it)

After, 1, 2 and 3 is done. We can safely remove Agent side hack.

@echlebek
Copy link
Contributor Author

echlebek commented Apr 9, 2024

The agent side hack has been shown to be buggy and does not work correctly in all circumstances. Per recent discussion, it should be removed.

@rnishtala-sumo
Copy link
Contributor

rnishtala-sumo commented Apr 19, 2024

@echlebek re: setting the opamp endpoint - the install script has moved to the packaging repository.

@echlebek
Copy link
Contributor Author

QE has found an issue with this PR, will update.

This commit removes a hack that rewrites the collector URL for use with
OpAmp. The collector now supports redirection, and we expect the Sumo
Logic backend to correctly redirect the client.
When the OpAmp URL is not explicitly configured, use the default
SumoLogic URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants