Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test otelcol configs from example directory #1173

Merged
merged 4 commits into from
Jun 26, 2023
Merged

chore: test otelcol configs from example directory #1173

merged 4 commits into from
Jun 26, 2023

Conversation

dmolenda-sumo
Copy link
Contributor

  • move otelcol configs to separate folder in examples
  • test config_logging.yaml and logs_json/config.yaml in collector_config_test.go (only these 2 because they don't contain sumologic extension which want to connect with sumo during startup)
  • fix bug in logs_json/config.yaml

@dmolenda-sumo dmolenda-sumo requested a review from a team as a code owner June 22, 2023 09:20
@github-actions github-actions bot added documentation Improvements or additions to documentation go labels Jun 22, 2023
swiatekm
swiatekm reviewed Jun 22, 2023
View reviewed changes
examples/README.md Show resolved Hide resolved
examples/otelcolconfigs/logs_json/config.yaml Outdated Show resolved Hide resolved
swiatekm
swiatekm approved these changes Jun 23, 2023
View reviewed changes
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmolenda-sumo dmolenda-sumo merged commit a353505 into SumoLogic:main Jun 26, 2023
@dmolenda-sumo dmolenda-sumo deleted the test-otelcol-configs-from-examples-directory branch June 26, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation go skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmolenda-sumo @swiatekm