Skip to content

Commit

Permalink
feat(build): make dev builds identical to release builds
Browse files Browse the repository at this point in the history
  • Loading branch information
Mikołaj Świątek committed Jun 26, 2023
1 parent 4f57d7f commit be8fdbf
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 63 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/dev_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
if: matrix.arch_os == 'linux_amd64'
run: |
cp otelcol-sumo-fips-${{ matrix.arch_os }} otelcol-sumo
make build-push-container-multiplatform-dev \
make build-push-container-multiplatform \
BUILD_TAG=${{ steps.extract_tag.outputs.tag }}-fips \
PLATFORM=${{ matrix.arch_os }} \
LATEST_TAG_FIPS_SUFFIX="-fips"
Expand All @@ -166,7 +166,7 @@ jobs:
- name: Build and push image to Open Source ECR
run: |
cp otelcol-sumo-${{ matrix.arch_os }} otelcol-sumo
make build-push-container-multiplatform-dev \
make build-push-container-multiplatform \
BUILD_TAG=${{ steps.extract_tag.outputs.tag }} \
PLATFORM=${{ matrix.arch_os }}
Expand Down
37 changes: 0 additions & 37 deletions Dockerfile_dev

This file was deleted.

24 changes: 0 additions & 24 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -254,30 +254,6 @@ build-container-dev:

#-------------------------------------------------------------------------------

# dev

.PHONY: _build-container-multiplatform-dev
_build-container-multiplatform-dev:
BUILD_TAG="$(BUILD_TAG)" \
REPO_URL="$(OPENSOURCE_REPO_URL_DEV)" \
DOCKERFILE="Dockerfile_dev" \
PLATFORM="$(PLATFORM)" \
./ci/build-push-multiplatform.sh $(PUSH)

.PHONY: build-container-multiplatform-dev
build-container-multiplatform-dev:
$(MAKE) _build-container-multiplatform-dev PUSH=

.PHONY: build-container-multiplatform-dev
build-push-container-multiplatform-dev:
$(MAKE) _build-container-multiplatform-dev PUSH=--push

.PHONY: push-container-manifest-dev
push-container-manifest-dev:
BUILD_TAG="$(BUILD_TAG)" \
REPO_URL="$(OPENSOURCE_REPO_URL_DEV)" \
./ci/push_docker_multiplatform_manifest.sh $(PLATFORMS)

# release

.PHONY: _build-container-multiplatform
Expand Down

0 comments on commit be8fdbf

Please sign in to comment.