feat(metrics): Define allowlist for histogram metrics #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rnishtala-sumo
force-pushed
the
histograms-allowlist
branch
from
f4296f3
to
8e3a9e7
Compare
rnishtala-sumo
commented
Aug 6, 2024
deploy/helm/sumologic/conf/metrics/collector/otelcol/config.yaml
Outdated
Show resolved
Hide resolved
rnishtala-sumo
force-pushed
the
histograms-allowlist
branch
3 times, most recently
from
9a30fba
to
616160f
Compare
rnishtala-sumo
force-pushed
the
histograms-allowlist
branch
7 times, most recently
from
959fceb
to
b73ff77
Compare
rnishtala-sumo
force-pushed
the
histograms-allowlist
branch
from
b73ff77
to
9ff3247
Compare
rnishtala-sumo
force-pushed
the
histograms-allowlist
branch
from
9ff3247
to
aaee19b
Compare
sumo-drosiek
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
LGTM, we need to document the change for customers on https://help.sumologic.com
jagan2221
added a commit
that referenced
this pull request
Sep 13, 2024
* feat: Add labels to setup Pods for easy logs collection (#3817) * Add labels to setup Pods for easy logs collection * Addressing comments * remove unwanted line * Addressing reviews and fixing bugs * Fixing name and indent * Fix test * Removing the extra space * Changed events to setup * feat(metrics): Define allowlist for histogram metrics (#3821) * feat(metrics): Define allowlist for histogram metrics * Adding template and integration tests * Removed KOPs 1.30, not supported yet (#3823) * docs(histogram-metrics): Updates to the doc around allowing histogram metrics (#3824) * chore: Upgrade OpenTelemetry Collector to 0.104.0-sumo-1 (#3829) * chore: update OpenTelemetry Collector to 0.104.0-sumo-1 * Remove deprecated compress_encoding to use compression * Change the bind address for the otel collector and the health check ext to the pod IP * Regenerate test files after changes to bind IP address configuration across all pods * Add otel collector labels to metrics collection * fix(metrics): Correct the name of k8s hpa metrics (part of kube-state-metrics) (#3832) * chore: Prepare release 4.10.0 (#3834) * feat: Add support for the Korea region of the Sumologic deployment (#3835) --------- Co-authored-by: Harsh Shah <[email protected]> Co-authored-by: Raj Nishtala <[email protected]> Co-authored-by: Tim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(metrics): Define allowlist for histogram metrics. This change introduces an allowlist for Histograms, using a regex, since we now disable all histogram metrics by default.