feat: do not send any histogram or summary metric #3818
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Please remember to add changelog entry. |
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-drop-all-histograms
branch
from
29cab66
to
d125e88
Compare
|
Not quite sure about that, but we may probably also want to do the same for summary metrics |
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-drop-all-histograms
branch
from
ac6afb3
to
7ef371f
Compare
sumo-drosiek
changed the title
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-drop-all-histograms
branch
from
9932698
to
f3f89b4
Compare
| @@ -16,7 +16,7 @@ filter/drop_unnecessary_metrics: | |||
| - resource.attributes["job"] != "pod-annotations" and IsMatch(name, "scrape_.*") | |||
| {{- if .Values.sumologic.metrics.dropHistogramBuckets }} | |||
| # drop histograms we've extracted sums and counts from, but don't want the full thing | |||
| - IsMatch(name, "^(apiserver_request_duration_seconds|coredns_dns_request_duration_seconds|kubelet_runtime_operations_duration_seconds)$") | |||
| - type == METRIC_DATA_TYPE_HISTOGRAM or type == METRIC_DATA_TYPE_EXPONENTIAL_HISTOGRAM or type == METRIC_DATA_TYPE_SUMMARY or IsMatch(name, ".*_bucket") | |||
There was a problem hiding this comment.
maybe we should allow one histogram metric to demonstrate, how a customer could make exceptions. Something like - not (IsMatch(name, "^(apiserver_request_duration_seconds)$")) and type == METRIC_DATA_TYPE_HISTOGRAM or type == METRIC_DATA_TYPE_EXPONENTIAL_HISTOGRAM or type == METRIC_DATA_TYPE_SUMMARY or IsMatch(name, ".*_bucket"
There was a problem hiding this comment.
I would expose new configuration option, and conditionally adding not isMatch at the end of the query
There was a problem hiding this comment.
I wouldn't play with merge if we can do it easily by the configuration option
| @@ -16,7 +16,7 @@ filter/drop_unnecessary_metrics: | |||
| - resource.attributes["job"] != "pod-annotations" and IsMatch(name, "scrape_.*") | |||
There was a problem hiding this comment.
should we also drop metrics coming in from pod annotations by default as well?
There was a problem hiding this comment.
It's breaking change
Checklist
Histogram is a lot of data points which are not used on Sumo Logic side by default. In case we will need to send some of them, we can figure out additional flag which will be an exception from that rule, but for now it sounds reasonable to stop ingesting buckets at all
The same is about summary and quantiles