Skip to content

Commit

Permalink
test: update test for prometheus
Browse files Browse the repository at this point in the history 
Signed-off-by: Dominik Rosiek <[email protected]>
  • Loading branch information
Dominik Rosiek committed Aug 1, 2024
1 parent a2b394e commit cd571e7
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deploy/helm/sumologic/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an
| `sumologic.metrics.collector.otelcol.config.merge` | Configuration for otelcol metrics collector, merged with defaults. See also https://github.com/SumoLogic/sumologic-otel-collector/blob/main/docs/configuration.md. | {} |
| `sumologic.metrics.collector.otelcol.config.override` | Configuration for otelcol metrics collector, replaces defaults. See also https://github.com/SumoLogic/sumologic-otel-collector/blob/main/docs/configuration.md. | {} |
| `sumologic.metrics.collector.otelcol.targetAllocator.resources` | Resource requests and limits for Metrics Collector Target Allocator. | {} |
| `sumologic.metrics.dropHistogramBuckets` | Drop buckets from select high-cardinality histogram metrics, leaving only the sum and count components. | `true` |
| `sumologic.metrics.dropHistogramBuckets` | Drop buckets from histogram and summary metrics, leaving only the sum and count components. | `true` |
| `sumologic.metrics.sourceType` | The type of the Sumo Logic source being used for metrics ingestion. Can be `http` or `otlp`. | `otlp` |
| `sumologic.traces.enabled` | Set the enabled flag to true to enable tracing ingestion. _Tracing must be enabled for the account first. Please contact your Sumo representative for activation details_ | `true` |
| `sumologic.traces.spans_per_request` | Maximum number of spans sent in single batch | `100` |
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/helm_prometheus_metrics_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func Test_Helm_Prometheus_Metrics(t *testing.T) {
// defaults without otel metrics collector metrics, but with Prometheus metrics
expectedMetricsGroups := make([][]string, len(internal.DefaultExpectedMetricsGroups))
copy(expectedMetricsGroups, internal.DefaultExpectedMetricsGroups)
expectedMetricsGroups = append(expectedMetricsGroups, internal.PrometheusMetrics, internal.DefaultOtelcolMetrics)
expectedMetricsGroups = append(expectedMetricsGroups, internal.PrometheusMetrics, internal.DefaultOtelcolMetrics, internal.BucketMetrics)
for _, metrics := range expectedMetricsGroups {
expectedMetrics = append(expectedMetrics, metrics...)
}
Expand Down
13 changes: 13 additions & 0 deletions tests/integration/internal/constants.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,19 @@ var (
"scrape_duration_seconds",
}

// Bucket metrics are completely removed in OTC, but there may be still available in Prometheus
BucketMetrics = []string{
"etcd_disk_wal_fsync_duration_seconds_bucket",
"scheduler_scheduling_attempt_duration_seconds_bucket",
"scheduler_scheduling_algorithm_duration_seconds_bucket",
"otelcol_processor_groupbyattrs_metric_groups_bucket",
"prometheus_remote_storage_sent_batch_duration_seconds_bucket",
"otelcol_processor_batch_batch_send_size_bucket",
"etcd_disk_backend_commit_duration_seconds_bucket",
"coredns_proxy_request_duration_seconds_bucket",
"scheduler_framework_extension_point_duration_seconds_bucket",
}

// Some metrics might change over k8s versions
versionDependentMetrics = map[*version.Version](struct {
before []string
Expand Down

0 comments on commit cd571e7

Please sign in to comment.