chore: add warning to Client.login #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleobal
force-pushed
the
chore/login-warning
branch
2 times, most recently
from
2eb5470
to
8c75074
Compare
Signed-off-by: Olivier Léobal <[email protected]>
Signed-off-by: Olivier Léobal <[email protected]>
Signed-off-by: Olivier Léobal <[email protected]>
oleobal
force-pushed
the
chore/login-warning
branch
from
8c75074
to
405a0c7
Compare
SdgJlbl
reviewed
Aug 1, 2023
Signed-off-by: Olivier Léobal <[email protected]>
oleobal
force-pushed
the
chore/login-warning
branch
from
0b4f115
to
33727c8
Compare
SdgJlbl
approved these changes
Aug 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a warning to
Client.logintelling you to use tokens from the frontend instead. Also tells you when your session will expire.I purposefully avoided calling it "deprecated" (since we have no plans to remove it), but maybe we should.
Also add a check for HTTP 410 on this endpoint, to match Substra/substra-backend#698 and provide a helpful error message.
See also Substra/substra-documentation#335
Closes FL-1112
Please check if the PR fulfills these requirements