chore(charts): allow using existing secrets #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbcmlowk
force-pushed
the
chore/use-existing-secrets
branch
2 times, most recently
from
847395d
to
b4d07f6
Compare
2 tasks
thbcmlowk
force-pushed
the
chore/use-existing-secrets
branch
2 times, most recently
from
5fd18eb
to
b08da8e
Compare
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
…tName Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
Signed-off-by: Thibault Camalon <[email protected]>
thbcmlowk
force-pushed
the
chore/use-existing-secrets
branch
from
b08da8e
to
1b69ac4
Compare
SdgJlbl
reviewed
Jul 5, 2024
| | Name | Description | Value | | ||
| | ---------------------------------- | ------------------------------------------------------------------------------------------------------------------- | ------ | | ||
| | `postgresql.enabled` | Deploy a PostgreSQL instance along the backend for its use | `true` | | ||
| | `database.auth.existingSecretName` | An alternative to giving username and password; must have `OBJECTSTORE_ACCESSKEY` and `OBJECTSTORE_SECRETKEY` keys. | `""` | |
SdgJlbl
reviewed
Jul 5, 2024
Comment on lines
+440
to
+441
| {{- if .Values.redis.auth.existingSecretName -}} | ||
| {{- .Values.database.auth.existingSecretName }} |
There was a problem hiding this comment.
🕵️
I think the values have not been changed here
SdgJlbl
reviewed
Jul 5, 2024
| */}} | ||
| {{- define "substra-backend.redis.secretName" -}} | ||
| {{- if .Values.redis.auth.existingSecretName -}} | ||
| {{- .Values.database.auth.existingSecretName }} |
There was a problem hiding this comment.
also, the new redis value has not been documented
There was a problem hiding this comment.
The redis section has:
## @skip redis
SdgJlbl
reviewed
Jul 5, 2024
| */}} | ||
| {{- define "substra-backend.accountOperator.secretName" -}} | ||
| {{- if .Values.addAccountOperator.existingSecretName -}} | ||
| {{- .Values.database.auth.existingSecretName }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of FL-1642
existingSecretNamekey for the following sectionsdatabaseaddAccountOperatorredisminioexistingSecretkey forpostgressection (see docs)How has this been tested?
Checklist