Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change to ubuntu base image for docker image #866

Merged
merged 24 commits into from
Apr 15, 2024
Merged

chore: change to ubuntu base image for docker image #866

merged 24 commits into from
Apr 15, 2024

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Mar 28, 2024 •
edited
Loading

Description

closes FL-1530

Trivy scan

12 middle and 8 low

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Mar 28, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Houston, we have a problem.” ― Jim Lovell, Apollo 13

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Mar 29, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Oh noes.

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Mar 29, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Epic fail.

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Mar 29, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

What a surprise... 🙄

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Apr 2, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Better luck next time!

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Apr 2, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Sorry, try again.

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Apr 2, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Boy, that escalated quickly.” ― Ron Burgundy, Anchorman: The Legend of Ron Burgundy

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Apr 2, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

I'm sorry.

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Apr 8, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

I'm sorry.

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Apr 10, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Oh well.

@linear Linear
Copy link

linear bot commented Apr 10, 2024

FL-1530 Change backend base docker image to ubuntu 23.10

@ThibaultFy
Copy link
Member Author

/e2e --tests mnist

@Owlfred
Copy link

Owlfred commented Apr 10, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“I’m sorry, Dave. I’m afraid I can’t do that.” ― Hal, 2001: A Space Odyssey

@ThibaultFy
Copy link
Member Author

/e2e --tests mnist, sdk

@Owlfred
Copy link

Owlfred commented Apr 10, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Awesome sauce!

@ThibaultFy ThibaultFy marked this pull request as ready for review April 11, 2024 07:08
@ThibaultFy ThibaultFy requested a review from a team as a code owner April 11, 2024 07:08
@ThibaultFy
Copy link
Member Author

/e2e --tests mnist, sdk

@Owlfred
Copy link

Owlfred commented Apr 11, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Crushed it!

guilhem-barthes
guilhem-barthes approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 🙏

guilhem-barthes
guilhem-barthes reviewed Apr 12, 2024
View reviewed changes
docker/substra-backend/Dockerfile Outdated
Comment on lines 8 to 9
&& apt-get install --no-install-recommends -y software-properties-common \
&& apt-get --no-install-recommends -y install python3-pip gcc python3.11-dev python3-watchdog celery python-is-python3 python3.11-venv \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could merge these two lines

Suggested change
&& apt-get install --no-install-recommends -y software-properties-common \
&& apt-get --no-install-recommends -y install python3-pip gcc python3.11-dev python3-watchdog celery python-is-python3 python3.11-venv \
&& apt-get install --no-install-recommends -y software-properties-common \
python3-pip gcc python3.11-dev python3-watchdog celery python-is-python3 python3.11-venv \

guilhem-barthes
guilhem-barthes reviewed Apr 12, 2024
View reviewed changes
docker/substra-backend/Dockerfile
Comment on lines 36 to +38
RUN apt-get update && apt-get install -y --no-install-recommends \
# libpq is a required dependency to build psycopg2 from source (support for arm64 platform)
libpq-dev
RUN pip3 install --upgrade --no-cache-dir pip==24.0 \
&& pip3 install --prefix /usr/local --no-cache-dir psycopg2==2.9.9
RUN pip install --no-cache-dir psycopg2==2.9.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we don't do it on line 19 / 20?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's only meant to be installed for arm64, it is under FROM build AS arm64

@ThibaultFy
chore: change to ubuntu base image for docker image
236d67d 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
lint
4f0a3fd 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
lint
57a6c41 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
lint
deb3078 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
lint
6e7be01 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
lint
9207ee2 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
fix
fc0caff 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
fix
84d45d2 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
fix
0487953 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
fix
14bdd71 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
fix
d8ee1da 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
fix
a04eb9d 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
fix
f4a2ac1 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: reduce number of CVEs in docker image
e7e2535 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: reduce number of CVEs in docker image
df393db 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: reduce number of CVEs in docker image
2c74ca9 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: rm ca-certificate from dockerfile
57b07b5 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
wip
af90e10 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: ubuntu base image
4f45b45 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: use venv
80c2013 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: use venv
9f6ab04 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: changelog
ab59b89 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: remove last hich CVEs
78c24f4 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: merge lines
5b727f2 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy ThibaultFy merged commit 87c1191 into main Apr 15, 2024
7 checks passed
@ThibaultFy ThibaultFy deleted the base-image-ubuntu branch April 15, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @Owlfred @guilhem-barthes