[sub]fix(backend/image_transfert/encoder): update pydantic method

[thbcmlowk]

Description

Closes FL-1242

How has this been tested?

Checklist

• changelog was updated with notable changes
• documentation was updated

[linear]

FL-1242 [BUG] `dumps_kwargs` keyword arguments are no longer supported

Context

FLPC v3 has been deployed

Test Compute Plan has been launched (Camelyon)

The following error is raised in the worker pod:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/celery/app/trace.py", line 451, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/celery/app/trace.py", line 734, in __protected_call__
    return self.run(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/celery/app/autoretry.py", line 34, in run
    return task._orig_run(*args, **kwargs)
  File "/usr/src/app/substrapp/tasks/tasks_save_image.py", line 83, in save_image_task
    make_payload(
  File "/usr/src/app/image_transfer/encoder.py", line 178, in make_payload
    create_zip_from_docker_images(
  File "/usr/src/app/image_transfer/encoder.py", line 136, in create_zip_from_docker_images
    zip_file.writestr("payload_descriptor.json", payload_descriptor.json(indent=4))
  File "/usr/local/lib/python3.9/site-packages/typing_extensions.py", line 2360, in wrapper
    return arg(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/pydantic/main.py", line 960, in json
    raise TypeError('`dumps_kwargs` keyword arguments are no longer supported.')
TypeError: `dumps_kwargs` keyword arguments are no longer supported.

One side effect is:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/celery/app/trace.py", line 451, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/celery/app/trace.py", line 734, in __protected_call__
    return self.run(*args, **kwargs)
  File "/usr/src/app/substrapp/tasks/tasks_asset_failure_report.py", line 53, in store_asset_failure_report
    failure_report = store_failure(exception, asset_key, asset_type, error_type)
  File "/usr/src/app/substrapp/utils/errors.py", line 27, in store_failure
    file = files.File(exception.logs)
AttributeError: 'TypeError' object has no attribute 'logs'

Environment

  substra_version = {
    "orchestrator" = {
      app   = "0.37.0-beta3"
      chart = "8.0.0"
    }
    "substra-backend" = {
      app   = "0.43.0-beta2"
      chart = "24.0.0-beta1"
    }
    "substra-frontend" = {
      app   = "0.46.0-beta3"
      chart = "1.0.24"
    }
    "substra-tools" = {
      app = "0.21.0"
    }
  }

Symptoms

Compute Plan launched is stuck in Doing while the builder is no longer busy

image.png

Specification

Fix the TypeError

Acceptance criteria

TypeError is not raised anymore by the worker

[ThibaultFy]

You need to change also PayloadDescriptor.parse_raw into PayloadDescriptor.model_validate_json in decoder.py

[thbcmlowk]

Nice catch! You mean here and like this, right?

-    return PayloadDescriptor.parse_raw(zip_file.read("payload_descriptor.json").decode())
+    return PayloadDescriptor.model_validate_json(zip_file.read("payload_descriptor.json").decode())

[ThibaultFy]

yep ! (I did it for the PR refactor image transfer that's why ^^")

[thbcmlowk]

Also made the pydantic upgrade, but still 🙂

[thbcmlowk]

Done!

[ThibaultFy]

perfect :)