-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: stop writing on root file system #671
Conversation
/e2e |
End to end tests: ✔️ SUCCESS Yay! 🎉 |
790f784
to
6a5e2a4
Compare
6a5e2a4
to
2638505
Compare
/e2e --help |
|
/e2e --tests sdk,substrafl,frontend |
38c47cb
to
10c2fb1
Compare
/e2e --tests sdk,substrafl,frontend |
/e2e --tests sdk,frontend |
/e2e --tests sdk just keep removing tests until it passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/e2e --tests sdk please? |
6a3a697
to
1318451
Compare
/e2e --tests sdk,frontend |
End to end tests: ✔️ SUCCESS That was easy. |
92feee4
to
9e21e28
Compare
/e2e --tests sdk,frontend |
End to end tests: ✔️ SUCCESS “It’s alive! It’s alive!” ― Henry Frankenstein, Frankenstein |
Signed-off-by: Olivier Léobal <[email protected]>
Signed-off-by: Olivier Léobal <[email protected]>
Signed-off-by: Olivier Léobal <[email protected]>
Signed-off-by: Olivier Léobal <[email protected]>
Signed-off-by: Olivier Léobal <[email protected]>
9cacbf7
to
20cb5e0
Compare
### Added - New `SECRET_KEY` optional environment variable ([#671](#671)) - `/api-token-auth/` and the associated tokens can now be disabled through the `EXPIRY_TOKEN_ENABLED` environment variable and `server.allowImplicitLogin` chart value ([#698](#698)) - Tokens issued by `/api-token-auth/` can now be deleted like other API tokens, through a `DELETE` request on the `/active-api-tokens` endpoint ([#698](#698)) ### Changed - Increase the number of tasks displayable in frontend workflow [#697](#697) - BREAKING: Change the format of many API responses from `{"message":...}` to `{"detail":...}` ([#705](#705)) ### Removed - BREAKING: `SECRET_KEY_PATH` and `SECRET_KEY_LOAD_AND_STORE` environment variables ([#671](#671)) - Removed logic for storing `SECRET_KEY` at startup, in order to increase stability; it should be done at a higher level, i.e. the chart ([#671](#671)) ## Fixed - `/api-token-auth/` sometimes handing out tokens that are about to expire ([#698](#698)) Signed-off-by: Milouu <[email protected]>
Description
(this PR replaces #657 because I messed up my branches, sorry)
Writing on the root filesystem fails when
readOnlyRootFilesystem
is set, which is the case in some environments, such as OpenShift. This PR fixes this.Since
SECRET_KEY
is now stored in a secret, it should also mostly fix "Given token is not valid for any token type" errors, which were due to application restart whereSECRET_KEY
was regenerated and users had to refresh their tokens (which were signed with the oldSECRET_KEY
)Reverts most changes from #668 >_>
Fixes FL-1000
Checklist