-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change updateStrategy of the server and the registry #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
strategy: | ||
type: Recreate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdyt of adding the field in the values file (just like the registry):
strategy: | |
type: Recreate | |
strategy: | |
type: {{ .Values.server.updateStrategy }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make it configurable through the values if you think it's cleaner, I don't see any case where we wouldn't want to use the Recreate
strategy since it's blocking the deployment because of the shared RWO PVC.
For the registry, we use an external chart, so we have to configure it through values.
No strong opinion in either direction though.
Signed-off-by: SdgJlbl <[email protected]>
a9fa6c1
to
2aeb34b
Compare
The default value seems to be Recreate, what this PR is changing? |
Default is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating 🙏
Fixes FL-1733
Server and registry pods should no longer hang in pending because of race condition on RWO PVC.
Untested yet.