Pass request to django's authenticate #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drozdowsky Thanks for the PR! Could you please add a changelog with a brief description of your PR? The procedure is outlined in CONTRIBUTING.md/Changelog. If you have any questions, feel free to ask them here. |
drozdowsky
force-pushed
the
request_in_auth
branch
from
140e0da
to
74b5bc2
Compare
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 247 247
Branches 25 25
=====================================
Hits 247 247
Continue to review full report at Codecov.
|
|
Hi @fitodic |
drozdowsky
force-pushed
the
request_in_auth
branch
from
74b5bc2
to
2b4125b
Compare
|
@drozdowsky Yes, the changelog is OK and you're welcome 🙂 Once merged, I'll initiate the deployment procedure so you can start using it. It should be available on PyPI shortly. |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ciao,
MR to fix upstream issue: jpadilla#455
Also django-axes requires request in authenticate
"RequestParameterRequired: AxesModelBackend requires calls to authenticate to pass
requestas an argument."