Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add loadBalancerSourceRanges field to restrict the the source ip range #551

Conversation

yandongxiao
Copy link
Collaborator

Description

Fixes: #548

Checklist

For operator, please complete the following checklist:

  • run make generate to generate the code.
  • run golangci-lint run to check the code style.
  • run make test to run UT.
  • run make manifests to update the yaml files of CRD.

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

@yandongxiao
Copy link
Collaborator Author

@UsamaMehboob

@UsamaMehboob
Copy link

thanks @yandongxiao . Sorry I did not find time last week to do this. I was gonna do today but looks like you have already done this. thanks again

@yandongxiao yandongxiao merged commit 2938429 into StarRocks:main Jun 25, 2024
6 checks passed
@yandongxiao yandongxiao added v1.9.7 enhancement New feature or request labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.9.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Load Balancer Source Ranges for Service Type Load Balancer
3 participants