fix (User) : remove jwt update after update user information (#106)

* fix (User) : remove jwt update after update user information * fix (Test) : fix tets
Star-Academy · Sep 8, 2024 · f842224 · f842224
1 parent e899001
commit f842224
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/AnalysisData/AnalysisData/Services/UserService/AdminService/AdminService.cs b/AnalysisData/AnalysisData/Services/UserService/AdminService/AdminService.cs
@@ -33,14 +33,15 @@ public async Task UpdateUserInformationByAdminAsync(Guid id, UpdateAdminDto upda
         {
             throw new AdminProtectedException();
         }
+
         await ValidateUserInformation(user, updateAdminDto);
         _validationService.EmailCheck(updateAdminDto.Email);
         _validationService.PhoneNumberCheck(updateAdminDto.PhoneNumber);
-        await CheckExistenceOfRole(user,updateAdminDto);
+        await CheckExistenceOfRole(user, updateAdminDto);
         await SetUpdatedInformation(user, updateAdminDto);
     }
 
-    private async Task ValidateUserInformation(User user,UpdateAdminDto updateAdminDto)
+    private async Task ValidateUserInformation(User user, UpdateAdminDto updateAdminDto)
     {
         var checkUsername = await _userRepository.GetUserByUsernameAsync(updateAdminDto.UserName);
         var checkEmail = await _userRepository.GetUserByEmailAsync(updateAdminDto.Email);
@@ -49,16 +50,14 @@ private async Task ValidateUserInformation(User user,UpdateAdminDto updateAdminD
             throw new DuplicateUserException();
     }
 
-    private async Task CheckExistenceOfRole(User user,UpdateAdminDto updateAdminDto)
+    private async Task CheckExistenceOfRole(User user, UpdateAdminDto updateAdminDto)
     {
         var role = await _roleRepository.GetRoleByNameAsync(updateAdminDto.RoleName);
         if (role == null)
         {
             throw new RoleNotFoundException();
         }
-
         await SetUpdatedInformation(user, updateAdminDto);
-        await _jwtService.UpdateUserCookie(user.Username, false);
     }
 
     private async Task SetUpdatedInformation(User user, UpdateAdminDto updateAdminDto)
@@ -76,7 +75,7 @@ private async Task SetUpdatedInformation(User user, UpdateAdminDto updateAdminDt
         user.RoleId = role.Id;
         await _userRepository.UpdateUserAsync(user.Id, user);
     }
-    
+
 
     public async Task<bool> DeleteUserAsync(Guid id)
     {

diff --git a/AnalysisData/TestProject/Services/UserService/AdminService/AdminServiceTests.cs b/AnalysisData/TestProject/Services/UserService/AdminService/AdminServiceTests.cs
@@ -79,10 +79,7 @@ await _userRepository
                 u.PhoneNumber == updateAdminDto.PhoneNumber &&
                 u.Role.RoleName == updateAdminDto.RoleName
             ));
-
-        await _jwtService
-            .Received()
-            .UpdateUserCookie(updateAdminDto.UserName, false);
+
     }
 
     [Fact]