Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase11 #10

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Phase11 #10

wants to merge 13 commits into from

Conversation

Alirezaja1384
Copy link
Collaborator

No description provided.

@@ -0,0 +1,84 @@
name: Release

on:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

این اوکیه ولی چرا حالت ساده‌تر push روی main رو انتخاب نکردی؟

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

یکم دست آدم رو بازتر میذاره. مثلا الان تنظیم کردم فقط موقعی که PRمون از phase05 مرج میشه اجرا بشه چون اگه سورس تغییر نکنه ایمیج نهایی هم تکراری میشه و فقط بی دلیل ورژن میخوره.

contents: write

outputs:
new_tag: ${{ steps.generate_tag.outputs.new_tag }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

این کجا استفاده می‌شه؟

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

فعلا جای خاصی استفاده نمیشه اما jobی که کارش tag زدنه به نظرم منطقی باشه تگی که زده رو هم برکردونه.

MINOR_STRING_TOKEN: feat
MAJOR_STRING_TOKEN: BREAKING

- name: Pure version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

چه نیازی به این کار هست؟

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

منظورتون pure_version هست؟ راستش چون actionی که استفاده کردم خودش tag میزنه و push میکنه و من میخواستم تگ ها قبلشون v داشته باشن WITH_V رو روشن گذاشتم اما ایمیج های داکر رو نمیخواستم v داشته باشن برای همین با sed حرف v رو از اول tag حذف میکنم و برمیگردونم. البته در نهایت هردو تگ با و بدون v رو گذاشتم برای داکر.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants