Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImageReference, ManagedViewUpdate, and Tiles #45

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Sep 11, 2024

Add ImageReference, ManagedViewUpdate, and Tiles

♻️ Current situation & Problem

This PR moves some infrastructure from other Spezi packages to SpeziViews (this includes SpeziScheduler, NAMS and SpeziDevices).

⚙️ Release Notes

  • Added ImageReference as a way to pass around image resources including system image names.
  • Added ManagedViewUpdate as a mechanism to manually trigger view updates include based on dates
  • Added SimpleTile and TileHeader as new layout components.

📚 Documentation

Reorganized some of the sections of the documentation catalog.

✅ Testing

Added snapshot testing for the new layout components.
We added an UI test to verify the behavior of @ManagedViewUpdate.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg changed the title Add ImageReference from SpeziDevices Add ImageReference, ManagedViewUpdate, and Tiles Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 78.68852% with 39 lines in your changes missing coverage. Please review.

Project coverage is 80.32%. Comparing base (0cdbcc6) to head (7eb5c52).

Files with missing lines Patch % Lines
Sources/SpeziViews/Model/ImageReference.swift 36.67% 19 Missing ⚠️
Sources/SpeziViews/Views/Tiles/SimpleTile.swift 69.45% 11 Missing ⚠️
Sources/SpeziViews/Views/Tiles/TileHeader.swift 88.89% 6 Missing ⚠️
...rces/SpeziViews/Properties/ManagedViewUpdate.swift 93.62% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   81.12%   80.32%   -0.80%     
==========================================
  Files          44       49       +5     
  Lines        1308     1458     +150     
==========================================
+ Hits         1061     1171     +110     
- Misses        247      287      +40     
Flag Coverage Δ
80.32% <78.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ources/SpeziPersonalInfo/Fields/NameFieldRow.swift 88.00% <ø> (-1.65%) ⬇️
...urces/SpeziPersonalInfo/Fields/NameTextField.swift 77.28% <ø> (-0.98%) ⬇️
...es/SpeziValidation/Views/VerifiableTextField.swift 93.94% <ø> (ø)
...eziViews/Environment/DefaultErrorDescription.swift 100.00% <ø> (ø)
...Views/Environment/ProcessingDebounceDuration.swift 50.00% <ø> (ø)
Sources/SpeziViews/Views/Button/AsyncButton.swift 66.95% <ø> (-0.82%) ⬇️
Sources/SpeziViews/Views/Text/MarkdownView.swift 69.82% <ø> (ø)
...s/SpeziViews/Views/Tiles/CompletedTileHeader.swift 100.00% <100.00%> (ø)
...rces/SpeziViews/Properties/ManagedViewUpdate.swift 93.62% <93.62%> (ø)
Sources/SpeziViews/Views/Tiles/TileHeader.swift 88.89% <88.89%> (ø)
... and 2 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cdbcc6...7eb5c52. Read the comment docs.

@Supereg Supereg marked this pull request as ready for review September 13, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant