Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigureTipKit Module #38

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Add ConfigureTipKit Module #38

merged 5 commits into from
Jun 26, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jun 24, 2024

Add ConfigureTipKit Module

♻️ Current situation & Problem

This PR adds the ConfigureTipKit module to easily configure TipKit (or require TipKit to be configured) across the Spezi framework ecosystem.

⚙️ Release Notes

  • Add new ConfigureTipKit module.

📚 Documentation

Documentation catalog was adjusted.

✅ Testing

Basic testing was added that calls the new code paths.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg; had a similar comment to StanfordSpezi/Spezi#106 about the SwiftLint dependency but apart from this and small docs improvements this PR looks good to me 🚀

Package.swift Outdated Show resolved Hide resolved
@PSchmiedmayer PSchmiedmayer added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.36%. Comparing base (0899c34) to head (1f3cfd4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   80.27%   80.36%   +0.09%     
==========================================
  Files          43       44       +1     
  Lines        1282     1298      +16     
==========================================
+ Hits         1029     1043      +14     
- Misses        253      255       +2     
Files Coverage Δ
Sources/SpeziViews/Modules/ConfigureTipKit.swift 87.50% <87.50%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0899c34...1f3cfd4. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements @Supereg! 🚀

@Supereg Supereg merged commit ff61e65 into main Jun 26, 2024
13 checks passed
@Supereg Supereg deleted the feature/configure-tipkit-module branch June 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants