Add flag to enable -warnings-as-errors Swift complier option #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
PSchmiedmayer
requested changes
Jun 29, 2024
There was a problem hiding this comment.
@pauljohanneskraft Thank you for adding this here! It would be great if we can
- Test this version of the GitHub action by pointing the workflow references in Enable Strict Concurrency Checking Spezi#104 to this feature branch (you can use
@feature/warnings-as-errorsin the workflow files) to verify that is behaving as expected - Finish up the Spezi by checking that warnings are detected as expected and things are passing when we have no warnings left.
- Merge this PR
- Update the Spezi PR to point to the release version of this GitHub action & merge the PR.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag to enable -warnings-as-errors Swift complier option
♻️ Current situation & Problem
Currently, there is no option to enable the
-warnings-as-errorsSwift compiler option, which is potentially required by this PR.⚙️ Release Notes
warningsAsErrorsflag to thebuild-and-testworkflows to enable the respective-warnings-as-errorsSwift compiler option. If not provided, the behavior remains the same as before.📚 Documentation
warningsAsErrorsparameter has been provided.✅ Testing
I couldn't test this yet, as I'm not sure what the workflow would be.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: