Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce jsonschema requirements to allow 3.2 #251

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Reduce jsonschema requirements to allow 3.2 #251

merged 3 commits into from
Sep 25, 2023

Conversation

james-bellamy
Copy link
Contributor

The project I'm working on has a hard requirement of jsonschema 3.2 so currently, we have to use a horrible workaround to utilise st2, I'm hoping to remove this conflict.

@james-bellamy
Copy link
Contributor Author

test it

@cognifloyd
Copy link
Member

cognifloyd commented Oct 4, 2022 •
edited
Loading

Try retriggerring by closing/reopening

@cognifloyd cognifloyd closed this Oct 4, 2022
@cognifloyd cognifloyd reopened this Oct 4, 2022
@cognifloyd cognifloyd closed this Oct 4, 2022
@cognifloyd cognifloyd reopened this Oct 4, 2022
@james-bellamy
Copy link
Contributor Author

The 3.6 tests are failing due to pep8 failing but that seems unrelated to my change -

  would reformat orquesta/tests/unit/conducting/test_workflow_conductor_data_flow.py
  would reformat orquesta/tests/unit/utils/test_strings.py
  
  Oh no! 💥 💔 💥
  2 files would be reformatted, 167 files would be left unchanged.
  Error: ERROR: InvocationError for command /home/runner/work/orquesta/orquesta/.tox/pep8/bin/black orquesta bin setup.py -l 100 --check (exited with code 1)

guzzijones
guzzijones approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I will try and get this pushed this week after I debug the unit test failure.

@arm4b
Copy link
Member

arm4b commented Sep 19, 2023 •
edited
Loading

@guzzijones makes sense to revive this PR? I'm guessing the dependency update might be helpful here.

arm4b
arm4b reviewed Sep 25, 2023
View reviewed changes
requirements.txt
@@ -1,7 +1,7 @@
chardet>=3.0.2,<4.0.0
eventlet
Jinja2>=2.11 # BSD License (3 clause)
jsonschema!=2.5.0,<3.0.0,>=2.0.0 # MIT
jsonschema!=2.5.0,>=2.0.0,<=3.2 # MIT
Copy link
Member

@arm4b arm4b Sep 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with <3.2 the PR really installed 3.1.1 version. Updated the requirements so it really installs 3.2.0

@arm4b arm4b merged commit d9a029b into StackStorm:master Sep 25, 2023
3 checks passed
@arm4b arm4b mentioned this pull request Oct 7, 2023
Closed
13 tasks
@arm4b arm4b mentioned this pull request Nov 10, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b left review comments

@guzzijones guzzijones guzzijones approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@james-bellamy @cognifloyd @arm4b @guzzijones