Fix ShipIt dependency linking. #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinfoley
force-pushed
the
explicit_linking_shipit
branch
from
89da07a
to
691371e
Compare
|
When will this be merged? I think it will fix my issues i am having using Squirrel.... |
|
Closing because this is covered by #242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to Squirrel attempted to link to ReactiveCocoa and Mantle in ShipIt, vs copying and compiling their source files into the ShipIt binary. This was done because, in certain environments, dylib was loading multiple copies of the classes, which was causing errors in ReactiveCocoa's assertions.
This PR actually removes the dependency classes from the Copy Files build step. It adds an additional build step to re-link ReactiveCocoa and Mantle, using @executable_path instead of @rpath, as @rpath linking was causing the same double loading problem in certain environments.