-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor open ephys #305
Open
h-mayorquin
wants to merge
5
commits into
SpikeInterface:main
Choose a base branch
from
h-mayorquin:fix_openephys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−6
Open
Refactor open ephys #305
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c5ba244
refactor open ephys
h-mayorquin ae9277f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6150261
zach suggestions
h-mayorquin b128d5e
merge
h-mayorquin bc1b6c0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain to me the case where you would have a probe_stagger but not need it? Or is it possible to have row stagger and column stagger and that is why you are checking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can help me to find terminology?
The value on the left
stagger
is the displacement for that specific row. Some rows are displaced and some are not and this calculated on theis_row_staggered
variable.In other words,
probe_stagger
is the global variable that characterized the probe whereasstagger
is the one of the row. Maybe it should be calledrow_stagger
orrow_displacement
? Any suggestions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this was more me misreading. Maybe to make it clearer I would day
The this helps emphasize a particular row whereas my confusion was
is_row_staggered
made me think you were doing a global check rather than a specific row. But that's a lot of typing. So this is a soft rec now that I see what you mean!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that that is simple change that would improve readability. Pushing it.