Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use built-in constant instead of a magic number #18

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Use built-in constant instead of a magic number #18

merged 2 commits into from
Feb 23, 2024

Commits on Feb 21, 2024

  1. Use built-in constant instead of a magic number 

    In job-security providing functions, it is critically important that
they be fully in line with best coding practices. Hence, instead of
using a well-known(ish!) hardcoded power of two, use u8::MAX to
truncate the u32 into a u8.
    @antifuchs
    antifuchs committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a696c83 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Use From instead of Into for better plausible deniability

    @antifuchs
    antifuchs committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    195eaf0 View commit details
    Browse the repository at this point in the history