Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce OctaminimalGaussianArray, smaller, faster but less accurate #595

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

milankl
Copy link
Member

@milankl milankl commented Oct 23, 2024

Motivated by #594 this reduces the number of grid points on the OctahedralGaussianGrid by starting at 4 points around the pole instead of 20. At nlat_half = 24, the default resolution, this yields 2400 grid points instead of 3168, i.e. -25%, hopefully making the parameterizations 25% faster, and the whole model by 12.5%-ish as parameterizations are currently more than 50% of total runtime.

Number of grid points per ring are (old, new)

julia> [(16+4i, 4i) for i in 1:24]
24-element Vector{Tuple{Int64, Int64}}:
 (20, 4)
 (24, 8)
 (28, 12)
 (32, 16)
 (36, 20)
 (40, 24)
 (44, 28)
 (48, 32)
 (52, 36)
 (56, 40)
 (60, 44)
 (64, 48)
 (68, 52)
 (72, 56)
 (76, 60)
 (80, 64)
 (84, 68)
 (88, 72)
 (92, 76)
 (96, 80)
 (100, 84)
 (104, 88)
 (108, 92)
 (112, 96)

@milankl milankl added performance 🚀 Faster faster! parameterizations 🌧️ Parameterizations of unresolved physical processes array types 🔢 LowerTriangularMatrices and RingGrids labels Oct 23, 2024
@milankl milankl changed the title Start OctahedralGaussianGrid with 4 points around pole Start octahedral grids with 4 points around pole Oct 23, 2024
@milankl milankl added grid 🌐 Points on a sphere and removed array types 🔢 LowerTriangularMatrices and RingGrids parameterizations 🌧️ Parameterizations of unresolved physical processes labels Oct 23, 2024
@milankl milankl changed the title Start octahedral grids with 4 points around pole Introduce OctaminimalGaussianArray, smaller, faster but less accurate Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid 🌐 Points on a sphere performance 🚀 Faster faster!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant