Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model constructors with positional SpectralGrid argument #593

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

milankl
Copy link
Member

@milankl milankl commented Oct 21, 2024

At the moment one has to write

model = PrimitiveWetModel(; spectral_grid, kwargs...)

to construct any model. To lower the confusion for beginners ("what's that ; for?") also allow for the spectral grid to be passed on as first positional argument, i.e.

model = PrimitiveWetModel(spectral_grid, kwargs...)

which is also consistent with how we create all model components.

@milankl milankl added the user interface 🎹 How users use our user interface label Oct 21, 2024
Copy link
Member

@maximilian-gelbrecht maximilian-gelbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am fine with that, as it's a required argument, this could avoid confusion.

@milankl milankl merged commit 210bd22 into main Oct 22, 2024
5 checks passed
@milankl milankl deleted the mk/spectral_grid branch October 22, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user interface 🎹 How users use our user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants