Bugfix in vertical advection #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I'm about to review the semi-implicit scheme for the documentation. From the GFDL model it seems that the previous time step is necessary, but I don't fully understand this. Technically every linear term that is solved semi-implicitly needs to be evaluated at the previous time step, but for the adiabatic conversion term for example I'm evaluating that term at the current time step and then move it back to the previous time step with a linear operator in spectral space. Maybe the same is possible here. I'll report back |
milankl
approved these changes
Aug 28, 2023
milankl
added
bug 🐞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to run a high-resolution simulation (convinced the stability problem was solved) to replace the high-res simulation in the docs but the simulation crashed with upwinding!
I figured that I had changed just a little bit the structure of the code in #362 before merging but just enough to leave a bug not caught by the test.
This PR fixes it
(also produces the high res simulation to put in the README)