Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpectralTransform for square LowerTriMats too #356

Merged
merged 5 commits into from
Aug 2, 2023
Merged

SpectralTransform for square LowerTriMats too #356

merged 5 commits into from
Aug 2, 2023

Conversation

milankl
Copy link
Member

@milankl milankl commented Jun 10, 2023 •
edited
Loading

So that both work

alms = randn(LowerTriangularMatrix{ComplexF64},32,32)
gridded(alms)

alms = randn(LowerTriangularMatrix{ComplexF64},33,32)
gridded(alms)

previously only the second (which is what's used inside the dynamical core) was working when externally used.

@milankl milankl added user interface 🎹 How users use our user interface transform ⬅️ ➡️ Our spherical harmonic transform, grid to spectral, spectral to grid labels Jun 10, 2023
@milankl
Copy link
Member Author

milankl commented Aug 2, 2023

@maximilian-gelbrecht this PR will change the set_vorticity etc functions slightly to adapt them to the needs of more flexibility with the LowerTriangularMatrix sizes

@milankl milankl merged commit 3ddb18a into main Aug 2, 2023
3 checks passed
@milankl milankl deleted the mk/spectrans branch August 3, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
transform ⬅️ ➡️ Our spherical harmonic transform, grid to spectral, spectral to grid user interface 🎹 How users use our user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@milankl