Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Row::toArray() respecting end column #3979

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Fix: Row::toArray() respecting end column #3979

merged 4 commits into from
Oct 26, 2023

Conversation

phillipfickl
Copy link
Contributor

1️⃣ Why should it be added? What are the benefits of this change?
See #3946
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No
3️⃣ Does it include tests, if possible?
Yes
4️⃣ Any drawbacks? Possible breaking changes?
I guess if somebody provided an endColumn in the past and expected it not to be taken into account, it could break something
5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@phillipfickl phillipfickl changed the title Fix end column Fix: Row::toArray() respecting end column Aug 11, 2023
@phillipfickl
Copy link
Contributor Author

@patrickbrouwers I know you're quite busy at the moment, but is there any chance you could take a look at this and merge it or give feedback?
Thank you for your time and work!

@patrickbrouwers
Copy link
Member

I'm out of office for a while. Will have a look when I'm back

@patrickbrouwers patrickbrouwers merged commit d69d5d0 into SpartnerNL:3.1 Oct 26, 2023
9 checks passed
@phillipfickl phillipfickl deleted the fix-endColumn branch October 26, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants