Allow passing of subaccount #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS - DO NOT MERGE
Refs #150. This work extracts
subaccountfrom thekwargs, but I'm not liking how it's the same chunk of code everywhere. The base resource modifications are simple, but passing in subaccount optionally per call, coupled with the subclassing/API design we've set up means we have to allowsubaccountto be extracted/passed through on all subclass requesting methods, which is meh.We could put a method on the base class like
extract_subaccount, but when we pass aroundkwargsand do apopit's operating on a scoped copy within that method (I tried it) and not thekwargs we passed in. I tried it, but maybe I'm doing something wrong.Requires some more thought. Additionally with the 2.x implementation under way, we might consider abandoning this as users can instantiate multiple copies of the lib with subaccount API keys.
Comments welcome.