Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #12, which thankfully was very isolated. The largest factor of the changes was making sure callers of
SparkPost.Endpoint.request/3
were updated to callSparkPost.Endpoint.request/5
correctly.request/5
is modeled to be identical to the underlyingHTTPoison.request
that it calls.The majority of the changes to tests were handled by updating the mocks, but as I mentioned in #13, I think these tests are very fragile since they are not testing the true functionality of the module. That being said, I've done some manual testing which works. 👌
I did make a small change to the config file layout which uses the typical tiered layout.
@ewandennis @richleland