Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose rollup transaction statuses over sequencer RPC #1243

Closed
wants to merge 10 commits into from

Conversation

neysofu
Copy link
Member

@neysofu neysofu commented Dec 20, 2023

This PR introduces transaction status monitoring via JSON-RPC to sov-sequencer.

Transactions can have one of four statuses:

  • Unknown.
  • Submitted, i.e. accepted into the mempool.
  • Published, i.e. published to the DA as part of a batch.
  • Finalized, i.e. part of a finalized DA block.

The core status tracking logic is inside tx_status.rs, although the changes to lib.rs and batch_builder.rs are also meaningful.

I've also extended the client logic in util.rs to support the new subscription endpoints.

TODO

Finalized block notifications. Blocked by #1294.

Testing

One integration test over JSON-RPC and two unit tests. Resource deallocation after subscriptions are dropped is also tested.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (a8a234c) 78.9% compared to head (e067dbe) 79.4%.

❗ Current head e067dbe differs from pull request most recent head 9f5c667. Consider uploading reports for the commit 9f5c667 to get more accurate results

Additional details and impacted files
Files Coverage Δ
full-node/sov-sequencer/src/tx_status.rs 100.0% <100.0%> (ø)
full-node/sov-sequencer/src/utils.rs 86.1% <100.0%> (+35.1%) ⬆️
...em/sov-modules-rollup-blueprint/src/runtime_rpc.rs 100.0% <100.0%> (ø)
rollup-interface/src/node/services/da.rs 0.0% <ø> (ø)
full-node/sov-sequencer/src/batch_builder.rs 97.1% <97.3%> (-0.1%) ⬇️
...ollup-interface/src/node/services/batch_builder.rs 0.0% <0.0%> (ø)
full-node/sov-sequencer/src/lib.rs 89.5% <86.9%> (-3.9%) ⬇️

... and 12 files with indirect coverage changes

@neysofu neysofu changed the title WIP: Expose rollup transaction statuses over sequencer RPC Expose rollup transaction statuses over sequencer RPC Jan 9, 2024
@neysofu neysofu marked this pull request as ready for review January 9, 2024 14:27
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
Signed-off-by: Filippo Costa <[email protected]>
@neysofu neysofu closed this Jan 24, 2024
@neysofu neysofu deleted the filippo/track-l2-txs branch January 24, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant